Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add versioned module installations #240

Merged
merged 4 commits into from
Nov 23, 2021
Merged

docs: add versioned module installations #240

merged 4 commits into from
Nov 23, 2021

Conversation

stijnmoreels
Copy link
Member

@stijnmoreels stijnmoreels commented Nov 23, 2021 •
edited
Loading

Add -MaximumVersion to Install-Module commands to be in line with the other Arcus docs, and not to wrongly guide consumers to the wrong version.

@netlify
Copy link

netlify bot commented Nov 23, 2021 •
edited
Loading

✔️ Deploy Preview for arcus-scripting ready!

🔨 Explore the source changes: a5884b6

🔍 Inspect the deploy log: https://app.netlify.com/sites/arcus-scripting/deploys/619ca49a463a5f0008ee6f8d

😎 Browse the preview: https://deploy-preview-240--arcus-scripting.netlify.app

@mbraekman
Copy link
Contributor

Would you use -MinimumVersion or -RequiredVersion?
Since -MininumVersion might also trigger the download of a newer available version, which might not be in line with that specific documentation-page.

Otherwise: 👍

@stijnmoreels
Copy link
Member Author

stijnmoreels commented Nov 23, 2021 •
edited
Loading

Would you use -MinimumVersion or -RequiredVersion? Since -MininumVersion might also trigger the download of a newer available version, which might not be in line with that specific documentation-page.

Otherwise: 👍

Oh, shoot, you're right. I mend, -MaximumVersion. 😅 .

@stijnmoreels
Copy link
Member Author

But maybe, -RequiredVersion is even better. 🤔 ...

@mbraekman
Copy link
Contributor

But maybe, -RequiredVersion is even better. 🤔 ...

-RequiredVersion is probably the only way you're 100% sure that the downloaded version will match what has been specified in the docs, so I would go for that option 😄

@stijnmoreels stijnmoreels merged commit 470cb01 into arcus-azure:master Nov 23, 2021
@stijnmoreels stijnmoreels deleted the docs/add-versioned-module-installations branch November 23, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbraekman mbraekman mbraekman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stijnmoreels @mbraekman